carpecodeum opened a new pull request, #7849: URL: https://github.com/apache/arrow-rs/pull/7849
# Which issue does this PR close? Closes #7842 (Add testing for invalid variants) # Rationale for this change After adding support for both fallible and infallible access to variants, @alamb pointed out that there aren't many tests for the validation system itself. CC - @scovich @friendlymatthew # What changes are included in this PR? This change adds the fuzzing @alamb requested: it generates valid variants using the builder, randomly corrupts them by flipping bits, then tests both validation paths (if validation passes, make sure access doesn't crash; if it fails, make sure error handling works properly) across many corruption scenarios plus specific malformed test cases. A huge thank you to @PinkCrow007, @mprammer, @alamb, and the rest of the CMU variant team for their continued support towards this project. # Are these changes tested? Yes, passing all the tests currently We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? # Are there any user-facing changes? No, tests are to make sure the validation system works fine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
