kou commented on code in PR #46910:
URL: https://github.com/apache/arrow/pull/46910#discussion_r2181353250


##########
ci/scripts/install_sccache.sh:
##########
@@ -39,30 +39,30 @@ 
SCCACHE_URL="https://github.com/mozilla/sccache/releases/download/v$VERSION/scca
 SCCACHE_ARCHIVE=sccache.tar.gz
 
 # Download archive and checksum
-curl -L $SCCACHE_URL --output $SCCACHE_ARCHIVE
-curl -L $SCCACHE_URL.sha256 --output $SCCACHE_ARCHIVE.sha256
+curl -L "$SCCACHE_URL" --output $SCCACHE_ARCHIVE
+curl -L "${SCCACHE_URL}.sha256" --output $SCCACHE_ARCHIVE.sha256
 echo "  $SCCACHE_ARCHIVE" >> $SCCACHE_ARCHIVE.sha256
 
-SHA_ARGS="--check --status"
+SHA_ARGS=(--check --status)
 
 # Busybox sha256sum uses different flags
 if sha256sum --version 2>&1 | grep -q BusyBox; then
   SHA_ARGS="-sc"

Review Comment:
   ```suggestion
     SHA_ARGS=("-sc")
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to