alamb commented on issue #7831: URL: https://github.com/apache/arrow-rs/issues/7831#issuecomment-3032509246
> > How about we just make them `Clone` rather than `Copy`? > > I don't think it is possible to maek `VariantMetadata` a reference without making it quite a bit harder to construct Variants (b/c you can't make them directly from the metadata/value you first need to make a `VariantMetadata` > > Yeah, I think the sweet spot will be to slim them down to use fewer bytes but not try to pass a reference. If we revoke `Copy` and only leave them `Clone`, the whole `Variant` enum will also need the same treatment. Is that acceptable? I think removing Copy from Variant is acceptable -- it will make people more aware about cloning I agree that slimming the objects down *AND* removing `Copy` sounds good -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
