Willem-J-an commented on PR #416: URL: https://github.com/apache/arrow-go/pull/416#issuecomment-3032782743
> Thanks for this, can you add a test for it? @zeroshade I've added a test with some sample data based on the pre-existing avro schema that was in the repo. It encodes the data to avro & to json, and validates when the avro is decoded that it matches the json. For the json encoder I aligned it to what I saw the arrow record as json produced. I'm wondering what happened here, as quite a few types were not working. Maybe hamba had some breaking changes and due to no tests they were not detected? What do you think about the reader_type switch cases that do not seem to be applicable anymore; are there valid cases where these are still needed or does it make sense to delete them? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
