pitrou commented on code in PR #46423:
URL: https://github.com/apache/arrow/pull/46423#discussion_r2183281348
##########
python/pyarrow/tensor.pxi:
##########
@@ -421,19 +421,19 @@ shape: {self.shape}"""
@staticmethod
def from_scipy(obj, dim_names=None):
"""
- Convert scipy.sparse.coo_matrix to arrow::SparseCOOTensor
+ Convert scipy.sparse.coo_array or scipy.sparse.coo_matrix to
arrow::SparseCOOTensor
Parameters
----------
- obj : scipy.sparse.csr_matrix
- The scipy matrix that should be converted.
+ obj : scipy.sparse.coo_array or scipy.sparse.coo_matrix
+ The scipy array or matrix that should be converted.
dim_names : list, optional
Names of the dimensions.
"""
import scipy.sparse
- if not isinstance(obj, scipy.sparse.coo_matrix):
+ if not (isinstance(obj, scipy.sparse.coo_array) or isinstance(obj,
scipy.sparse.coo_matrix)):
Review Comment:
More succinctly, you can use `isinstance` with a tuple of classes.
```suggestion
if not isinstance(obj, (scipy.sparse.coo_array,
scipy.sparse.coo_matrix)):
```
##########
python/pyarrow/tensor.pxi:
##########
@@ -732,19 +733,19 @@ shape: {self.shape}"""
@staticmethod
def from_scipy(obj, dim_names=None):
"""
- Convert scipy.sparse.csr_matrix to arrow::SparseCSRMatrix.
+ Convert scipy.sparse.csr_array or scipy.sparse.csr_matrix to
arrow::SparseCSRMatrix.
Parameters
----------
- obj : scipy.sparse.csr_matrix
+ obj : scipy.sparse.csr_array or scipy.sparse.csr_matrix
The scipy matrix that should be converted.
dim_names : list, optional
Names of the dimensions.
"""
import scipy.sparse
- if not isinstance(obj, scipy.sparse.csr_matrix):
+ if not (isinstance(obj, scipy.sparse.csr_array) or isinstance(obj,
scipy.sparse.csr_matrix)):
Review Comment:
Same
##########
python/pyarrow/tensor.pxi:
##########
@@ -973,19 +974,19 @@ shape: {self.shape}"""
@staticmethod
def from_scipy(obj, dim_names=None):
"""
- Convert scipy.sparse.csc_matrix to arrow::SparseCSCMatrix
+ Convert scipy.sparse.csc_array or scipy.sparse.csc_matrix to
arrow::SparseCSCMatrix
Parameters
----------
- obj : scipy.sparse.csc_matrix
+ obj : scipy.sparse.csc_array or scipy.sparse.csc_matrix
The scipy matrix that should be converted.
dim_names : list, optional
Names of the dimensions.
"""
import scipy.sparse
- if not isinstance(obj, scipy.sparse.csc_matrix):
+ if not (isinstance(obj, scipy.sparse.csc_array) or isinstance(obj,
scipy.sparse.csc_matrix)):
Review Comment:
Same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
