zhuqi-lucas commented on code in PR #7860:
URL: https://github.com/apache/arrow-rs/pull/7860#discussion_r2184192296
##########
arrow/benches/sort_kernel.rs:
##########
@@ -113,6 +113,16 @@ fn add_benchmark(c: &mut Criterion) {
b.iter(|| bench_sort_to_indices(&arr, None))
});
+ let arr = create_string_array::<i32>(2usize.pow(12), 0.0);
Review Comment:
Good point @alamb , i agree, submit a PR to add rich sort string testing
cases first:
https://github.com/apache/arrow-rs/pull/7867
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
