zhjwpku commented on code in PR #46999:
URL: https://github.com/apache/arrow/pull/46999#discussion_r2187324967
##########
cpp/src/arrow/filesystem/mockfs.cc:
##########
@@ -187,6 +184,11 @@ class Entry : public EntryBase {
ARROW_DISALLOW_COPY_AND_ASSIGN(Entry);
};
+void Directory::AssignEntry(const std::string& s, std::unique_ptr<Entry>
entry) {
Review Comment:
The AssignEntry implementation is now placed after the full definition of
Entry so it can access its structure. Previously, Entry was only forward
declared, and as the error message indicated, the `sizeof` a forward
declaration is 0, which triggered the static_assert.
I'm not sure this is the most appropriate fix, though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
