Willem-J-an commented on PR #416:
URL: https://github.com/apache/arrow-go/pull/416#issuecomment-3045815451
Tests that are being removed? I think no tests are being removed?
As an example, the cases that I'm referring to is this:
```
func appendFixedSizeBinaryData(b *array.FixedSizeBinaryBuilder, data
interface{}) {
switch dt := data.(type) {
case nil: # <- is fine of course
b.AppendNull()
case []byte: # <- this case does not apply at least in my testing
because hamba decoder returns array, not a slice
b.Append(dt)
case map[string]any: # <- this case also didn't apply in my testing
switch v := dt["bytes"].(type) {
case nil:
b.AppendNull()
case []byte:
b.Append(v)
}
```
Not sure if these are legacy or still relevant in cases that I cannot
oversee!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
