alamb commented on code in PR #7871:
URL: https://github.com/apache/arrow-rs/pull/7871#discussion_r2190748273
##########
parquet-variant/src/variant.rs:
##########
@@ -297,8 +297,10 @@ impl<'m, 'v> Variant<'m, 'v> {
///
/// [unvalidated]: Self#Validation
pub fn new(metadata: &'m [u8], value: &'v [u8]) -> Self {
- let metadata = VariantMetadata::try_new_impl(metadata).expect("Invalid
variant metadata");
- Self::try_new_with_metadata_impl(metadata, value).expect("Invalid
variant data")
+ let metadata =
VariantMetadata::try_new_with_shallow_validation(metadata)
Review Comment:
This is a very nice name change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
