kou commented on code in PR #47017: URL: https://github.com/apache/arrow/pull/47017#discussion_r2191280567
########## cpp/src/arrow/flight/sql/odbc/odbcabstraction/calendar_utils.cc: ########## @@ -17,6 +17,7 @@ #include "odbcabstraction/calendar_utils.h" +#include <boost/date_time/posix_time/posix_time.hpp> Review Comment: Can we use `std::chrono` instead of Boost? (Currently, Arrow C++ requires C++17 but we'll require C++20 soon https://github.com/apache/arrow/issues/44792 . So we can use C++20 in ODBC support.) In general, we want to avoid using Boost as much as possible. It's difficult to maintain. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
