wgtmac commented on code in PR #46992:
URL: https://github.com/apache/arrow/pull/46992#discussion_r2191421045
##########
cpp/src/parquet/statistics.h:
##########
@@ -128,9 +128,14 @@ class PARQUET_EXPORT EncodedStatistics {
const std::string& max() const { return max_; }
const std::string& min() const { return min_; }
+ bool is_max_value_exact = false;
Review Comment:
While I know this is to keep the consistency of `EncodedStatistics`, I have
proposed to refactor this class to do something like `std::optional<bool>
is_min_value_exact` to combine flag and value into a single field. I think it
is an acceptable breaking change to make it simpler. Perhaps we can add these
two new fields like this and then refactor other fields in a separate change?
cc @mapleFU @pitrou
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
