kou commented on code in PR #46385:
URL: https://github.com/apache/arrow/pull/46385#discussion_r2191576547
##########
cpp/src/arrow/array/statistics_test.cc:
##########
@@ -152,4 +163,19 @@ TEST_F(TestArrayStatisticsEqualityDoubleValue,
ApproximateEquals) {
ASSERT_TRUE(statistics1_.Equals(statistics2_,
options_.atol(1e-3).use_atol(true)));
}
+TEST_F(TestArrayStatisticsEqualityDoubleValue, DoubleAttributeCombination) {
+ statistics1_.max = 0.5;
+ ASSERT_FALSE(statistics1_.Equals(statistics2_));
+ statistics2_.max = 0.5;
+ ASSERT_TRUE(statistics1_.Equals(statistics2_));
+ statistics1_.min = 0.5;
+ ASSERT_FALSE(statistics1_.Equals(statistics2_));
+ statistics2_.min = 0.5;
Review Comment:
Hmm. I think that this case should be detected by existing other `min`/`max`
tests... With the incorrect code, `min`/`max` are ignored. So existing
`min`/`max` tests should detect it.
(I still think that we don't need `min`/`max` here for this case.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
