Dandandan commented on code in PR #7873:
URL: https://github.com/apache/arrow-rs/pull/7873#discussion_r2192072520
##########
arrow-array/src/array/byte_view_array.rs:
##########
@@ -501,71 +501,17 @@ impl<T: ByteViewType + ?Sized> GenericByteViewArray<T> {
// allocate exactly the capacity needed for all non‑inline data
let mut data_buf = Vec::with_capacity(total_large);
- // 3) Iterate over all views and convert them into a new
- let mut views_buf = vec![0u128; len];
+ let mut views_buf: Vec<u128> = vec![0u128; len];
Review Comment:
For `else {` case we don't have to create `views_buf` here (now it does an
additional allocation / zeroing the `Vec`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
