pitrou commented on code in PR #46992:
URL: https://github.com/apache/arrow/pull/46992#discussion_r2192896986
##########
cpp/src/parquet/statistics_test.cc:
##########
@@ -459,6 +459,10 @@ class TestStatistics : public PrimitiveTypedTest<TestType>
{
EXPECT_TRUE(enc_stats->has_max);
EXPECT_EQ(expected_stats->EncodeMin(), enc_stats->min());
EXPECT_EQ(expected_stats->EncodeMax(), enc_stats->max());
+ EXPECT_TRUE(enc_stats->is_min_value_exact.has_value());
+ EXPECT_TRUE(enc_stats->is_max_value_exact.has_value());
+ EXPECT_TRUE(enc_stats->is_min_value_exact);
+ EXPECT_TRUE(enc_stats->is_max_value_exact);
Review Comment:
You might be able to condense this to:
```suggestion
EXPECT_EQ(enc_stats->is_min_value_exact, std::make_optional(true));
EXPECT_EQ(enc_stats->is_max_value_exact, std::make_optional(true));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
