amoeba commented on code in PR #3099:
URL: https://github.com/apache/arrow-adbc/pull/3099#discussion_r2193189638
##########
ci/scripts/rust_test.sh:
##########
@@ -26,5 +26,6 @@ export
LD_LIBRARY_PATH="${cpp_libs_dir}/lib:${LD_LIBRARY_PATH:-}"
export DYLD_LIBRARY_PATH="${cpp_libs_dir}/lib:${DYLD_LIBRARY_PATH:-}"
pushd "${source_dir}"
+export
ADBC_DRIVER_MANAGER_TEST_LIB="${cpp_libs_dir}/lib/libadbc_driver_sqlite.so"
Review Comment:
```suggestion
case "$(uname)" in
Linux) EXT="so" ;;
Darwin) EXT="dylib" ;;
MINGW*|MSYS*) EXT="dll" ;;
esac
export
ADBC_DRIVER_MANAGER_TEST_LIB="${cpp_libs_dir}/lib/libadbc_driver_sqlite.${EXT:-}"
```
##########
ci/scripts/rust_test.sh:
##########
@@ -26,5 +26,6 @@ export
LD_LIBRARY_PATH="${cpp_libs_dir}/lib:${LD_LIBRARY_PATH:-}"
export DYLD_LIBRARY_PATH="${cpp_libs_dir}/lib:${DYLD_LIBRARY_PATH:-}"
pushd "${source_dir}"
+export
ADBC_DRIVER_MANAGER_TEST_LIB="${cpp_libs_dir}/lib/libadbc_driver_sqlite.so"
Review Comment:
CI isn't exercising this script but do we want to try to stay as
crossplatform as possible?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
