adamreeve commented on code in PR #47032:
URL: https://github.com/apache/arrow/pull/47032#discussion_r2193944525
##########
cpp/src/parquet/column_writer_test.cc:
##########
@@ -938,6 +939,60 @@ TEST_F(TestByteArrayValuesWriter, CheckDefaultStats) {
ASSERT_TRUE(this->metadata_is_stats_set());
}
+// Test for https://github.com/apache/arrow/issues/47027.
+// When writing a repeated column with page indexes enabled
+// and batches that are aligned with list boundaries,
+// pages should be written after reaching the page limit.
+TEST_F(TestValuesWriterInt32Type, PagesSplitWithListAlignedWrites) {
Review Comment:
Yes I think this is covered by the
`TestColumnWriter.WriteDataPagesChangeOnRecordBoundariesWithSmallBatches` test.
One of the columns in that test has some writes that end up aligned with the
start of a list, so I had to adjust the expected results, but I think this
extra test where all writes are aligned is worth keeping.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
