ZENOTME commented on PR #47004: URL: https://github.com/apache/arrow/pull/47004#issuecomment-3052773168
> I'm curious how this came up given it's an internal API (or did something internal trigger this?) No, seems there is no use `reset` internally now. And I happen to find this when I refer how arrow use opentelemetry and play around with the api. > But we could also change valid to check for a null details right? That said just having an empty span is fine enough. Yes. But personally I think reset content inside SpanImpl maybe bettter because the `reset` make people think we can reuse it after reset and they may write something like following(that's why I trigger this at first time actually) : ``` span.reset(); RewrapSpan(span, ..); ``` > Do you want to add a small unit test to ensure this invariant holds (either way)? I'd like to add unit test to ensure the invariant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
