alamb commented on code in PR #7834:
URL: https://github.com/apache/arrow-rs/pull/7834#discussion_r2197694675
##########
arrow-avro/src/reader/record.rs:
##########
@@ -37,34 +36,43 @@ use std::sync::Arc;
const DEFAULT_CAPACITY: usize = 1024;
/// Decodes avro encoded data into [`RecordBatch`]
+#[derive(Debug)]
pub struct RecordDecoder {
schema: SchemaRef,
fields: Vec<Decoder>,
use_utf8view: bool,
+ strict_mode: bool,
}
impl RecordDecoder {
/// Create a new [`RecordDecoder`] from the provided [`AvroDataType`] with
default options
pub fn try_new(data_type: &AvroDataType) -> Result<Self, ArrowError> {
- Self::try_new_with_options(data_type, ReadOptions::default())
+ Self::try_new_with_options(data_type, false, false)
Review Comment:
We could also make the configuration more self documenting like
```suggestion
Self::new(data_type)
.with_utf8_view(true),
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
