zhuqi-lucas commented on PR #7873: URL: https://github.com/apache/arrow-rs/pull/7873#issuecomment-3057991363
> FWIW the benchmarks failed with the following panic > > ```shell > cargo bench --features=arrow,async,test_common,experimental --bench view_types > ``` > > ... > > ``` > > Benchmarking gc view types slice half without nulls[8000] > Benchmarking gc view types slice half without nulls[8000]: Warming up for 3.0000 s > Benchmarking gc view types slice half without nulls[8000]: Collecting 100 samples in estimated 5.1026 s (187k iterations) > Benchmarking gc view types slice half without nulls[8000]: Analyzing > gc view types slice half without nulls[8000] > time: [27.199 µs 27.268 µs 27.342 µs] > > Benchmarking view types slice > Benchmarking view types slice: Warming up for 3.0000 s > > thread 'main' panicked at arrow-buffer/src/buffer/immutable.rs:297:9: > the offset of the new Buffer cannot exceed the existing length: slice offset=0 length=800000 selflen=128000 > note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace > > error: bench failed, to rerun pass `-p arrow-array --bench view_types` > ``` Thank you @alamb , my bad for another adding new benchmark PR, make the len broken for view types slice, submitted a quick fix now: https://github.com/apache/arrow-rs/pull/7892 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
