toddmeng-db commented on code in PR #3132:
URL: https://github.com/apache/arrow-adbc/pull/3132#discussion_r2198902644
##########
csharp/src/Drivers/Apache/Hive2/HiveServer2Statement.cs:
##########
@@ -523,6 +523,9 @@ protected virtual async Task<QueryResult>
GetColumnsAsync(CancellationToken canc
cancellationToken);
OperationHandle = resp.OperationHandle;
Review Comment:
It looks like our tests do not test for Dispose (which needs to be called
explicitly)
##########
csharp/src/Drivers/Apache/Hive2/HiveServer2Statement.cs:
##########
@@ -523,6 +523,9 @@ protected virtual async Task<QueryResult>
GetColumnsAsync(CancellationToken canc
cancellationToken);
OperationHandle = resp.OperationHandle;
Review Comment:
It looks like our tests do not test for Dispose (which needs to be called
explicitly). I will add some test suites
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
