scovich commented on code in PR #7878: URL: https://github.com/apache/arrow-rs/pull/7878#discussion_r2200568325
########## parquet-variant/src/decoder.rs: ########## @@ -200,6 +200,24 @@ impl OffsetSizeBytes { } } +pub(crate) fn map_bytes_to_offsets( Review Comment: The rustc optimizes and specializes super aggresively -- the specialization you show is for a single-element iterator -- it doesn't even have a loop. But agree that using `chunks` (rather than `chunks_exact`) means it shouldn't be able to panic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org