returnString edited a comment on pull request #9970:
URL: https://github.com/apache/arrow/pull/9970#issuecomment-817931084


   Thinking more about this: do we need to be careful about numeric limits? 
E.g. the current implementation of `AvgAccumulator` in the physical plan tracks 
the whole sum and count, and does `sum / count` at the end, meaning we might 
hit `i64::MAX` in the sum component given enough entries in an `avg` input with 
a sufficiently high-precision timestamp type.
   
   Edit: don't mind me, it forces an f64 accumulator - I saw `ScalarValue` and 
panicked :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to