alamb opened a new pull request, #7911: URL: https://github.com/apache/arrow-rs/pull/7911
Draft as it Builds on https://github.com/apache/arrow-rs/pull/7905 # Which issue does this PR close? - Follow on to https://github.com/apache/arrow-rs/pull/7905 # Rationale for this change In a quest to have the fastest and most efficient Variant implementation I would like to avoid copies if at all possible Right now, to make a VariantArray first requires completing an individual buffer and appending it to the array. Let's make that faster by having the VariantBuilder append directly into the buffer # What changes are included in this PR? 1. Add `VariantBuilder::new_from_existing` 2. Add a `VariantArrayBuilder::variant_builder` that reuses the buffers TODO: - [ ] Tests for internal builder (both with and without calling `drop`) - [ ] Doc examples - [ ] Performance tests # Are these changes tested? 1. New unit tests 1. Yes by existing tests # Are there any user-facing changes? Hopefully faster performance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
