emkornfield commented on a change in pull request #9724:
URL: https://github.com/apache/arrow/pull/9724#discussion_r611762611
##########
File path:
java/gandiva/src/test/java/org/apache/arrow/gandiva/evaluator/ProjectorTest.java
##########
@@ -1229,6 +1229,53 @@ public void testInExpr() throws GandivaException,
Exception {
eval.close();
}
+ @Test
+ public void testInExprDouble() throws GandivaException, Exception {
+ Field c1 = Field.nullable("c1", float64);
+
+ TreeNode inExpr =
+ TreeBuilder.makeInExpressionDouble(TreeBuilder.makeField(c1),
+ Sets.newHashSet(1.0, -0.0, 3.0, 4.0, Double.NaN,
+ Double.POSITIVE_INFINITY,
Double.NEGATIVE_INFINITY));
+ ExpressionTree expr = TreeBuilder.makeExpression(inExpr,
Field.nullable("result", boolType));
+ Schema schema = new Schema(Lists.newArrayList(c1));
+ Projector eval = Projector.make(schema, Lists.newArrayList(expr));
+
+ int numRows = 16;
+ byte[] validity = new byte[]{(byte) 255, 0};
+ double[] c1Values = new double[]{1, -0.0, Double.NEGATIVE_INFINITY ,
Double.POSITIVE_INFINITY, Double.NaN,
+ 6, 7, 8, 9, 10, 11, 12, 13, 14, 4 , 3};
+
+ ArrowBuf c1Validity = buf(validity);
+ ArrowBuf c1Data = doubleBuf(c1Values);
+ ArrowBuf c2Validity = buf(validity);
+
+ ArrowFieldNode fieldNode = new ArrowFieldNode(numRows, 0);
+ ArrowRecordBatch batch =
+ new ArrowRecordBatch(
+ numRows,
+ Lists.newArrayList(fieldNode, fieldNode),
+ Lists.newArrayList(c1Validity, c1Data, c2Validity));
+
+ BitVector bitVector = new BitVector(EMPTY_SCHEMA_PATH, allocator);
+ bitVector.allocateNew(numRows);
+
+ List<ValueVector> output = new ArrayList<ValueVector>();
+ output.add(bitVector);
+ eval.evaluate(batch, output);
+
+ for (int i = 0; i < 4; i++) {
Review comment:
logic in tests make them very hard to read/understand after they are
checked in. Is there anyway to make the intent of these tests clearer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
