zeroshade commented on code in PR #7905:
URL: https://github.com/apache/arrow-rs/pull/7905#discussion_r2201733760
##########
parquet-variant-compute/src/from_json.rs:
##########
@@ -135,43 +68,38 @@ mod test {
None,
]);
let array_ref: ArrayRef = Arc::new(input);
- let output = batch_json_string_to_variant(&array_ref).unwrap();
+ let variant_array = batch_json_string_to_variant(&array_ref).unwrap();
- let struct_array = &output;
- let metadata_array = struct_array
- .column(0)
- .as_any()
- .downcast_ref::<BinaryArray>()
- .unwrap();
- let value_array = struct_array
- .column(1)
- .as_any()
- .downcast_ref::<BinaryArray>()
- .unwrap();
+ let metadata_array = variant_array.metadata_field().as_binary_view();
+ let value_array = variant_array.value_field().as_binary_view();
- assert!(!struct_array.is_null(0));
- assert!(struct_array.is_null(1));
- assert!(!struct_array.is_null(2));
- assert!(!struct_array.is_null(3));
- assert!(struct_array.is_null(4));
+ // Compare row 0
+ assert!(!variant_array.is_null(0));
+ assert_eq!(variant_array.value(0), Variant::Int8(1));
Review Comment:
That's also how the Go VariantArray works as well, `Value()` on the
`VariantArray` returns a `Variant` (performing the consolidation if the
underlying `VariantArray` is shredded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
