friendlymatthew commented on code in PR #7912:
URL: https://github.com/apache/arrow-rs/pull/7912#discussion_r2202049505


##########
parquet-variant/src/builder.rs:
##########
@@ -1916,6 +1989,80 @@ mod tests {
         assert_eq!(metadata.num_field_names(), 3);
     }
 
+    /// Test reusing buffers with nested objects
+    #[test]
+    fn test_with_existing_buffers_nested() {

Review Comment:
   If you apply this diff, it should give you what you need: 
https://github.com/apache/arrow-rs/pull/7914. 
   
   I don't _love_ that we need to use a builder to reencode the object/list. 
I'm going to spend some time thinking about a more elegant solution. 
   
   I wonder if this PR with its existing buffers can help 🤔 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to