abacef commented on code in PR #7914:
URL: https://github.com/apache/arrow-rs/pull/7914#discussion_r2202086488
##########
parquet-variant/src/builder.rs:
##########
@@ -707,7 +782,13 @@ impl VariantBuilder {
/// builder.append_value(42i8);
/// ```
pub fn append_value<'m, 'd, T: Into<Variant<'m, 'd>>>(&mut self, value: T)
{
- self.buffer.append_non_nested_value(value);
+ let variant = value.into();
+
+ match variant {
+ Variant::Object(obj) => self.append_object(obj),
Review Comment:
Should we create a clone of this `append_value` function using the
`try_append` functions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
