JigaoLuo opened a new pull request, #7918: URL: https://github.com/apache/arrow-rs/pull/7918
# Which issue does this PR close? Closes #7910 # Rationale for this change There is a copy from my issue page: https://github.com/apache/arrow-rs/blob/2be261b78b16a4aa7b5b9aece648bec663c0dbf1/parquet/src/file/serialized_reader.rs#L471-L472 > My concern is about the type of offset in SerializedPageReaderState. Should it be u64 instead of usize? If I understand correctly, this offset represents a global position within a Parquet file, which can easily exceed 4 GB. On 32-bit environments (e.g., WebAssembly), usize is limited to u32's max, which could lead to problems with larger files. # What changes are included in this PR? This PR does type changes only for `SerializedPageReaderState.offset` & `remaining_bytes` # Are these changes tested? I can pass with local unit tests via `cargo test -p parquet` # Are there any user-facing changes? No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
