alamb commented on PR #7819: URL: https://github.com/apache/arrow-rs/pull/7819#issuecomment-3065981599
> The reason why I am questioning the validity of these benchmark results is because the only bench that touches the code path of the function I changed is `bench_struct_list`, so I would expect only this bench to change if at all. The only other thing I could think of is if the rust compiler is choosing to optimize the code less since we are adding more code complexity with ryu and itoa? Yeah, I agree the benchmark results look suspicious. It could also be a difference in architecture (perhaps your machine / rust settings do better with what is in itoa / ryu than what is done on the relatively crappy x86_64 gcp machine I am using) If your performance results reproducible on another machine? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
