mbrobbel commented on code in PR #3146: URL: https://github.com/apache/arrow-adbc/pull/3146#discussion_r2204293056
########## rust/core/src/driver_manager.rs: ########## @@ -1894,6 +1894,7 @@ mod tests { #[cfg_attr(not(feature = "driver_manager_test_lib"), ignore)] fn test_load_driver_env() { // ensure that we fail without the env var set + env::remove_var("ADBC_CONFIG_PATH"); Review Comment: With tests running parallel (default) and other tests also setting this env var there is a race. Instead we could use https://crates.io/crates/temp-env or https://crates.io/crates/serial_test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org