jhorstmann commented on issue #7909: URL: https://github.com/apache/arrow-rs/issues/7909#issuecomment-3072820816
> The [current reader code](https://github.com/apache/arrow-rs/blob/1b8cd9ace2e746a073ee7204db5d0d0cfec67d31/parquet/src/file/metadata/reader.rs#L1046C20-L1055C22) for interpreting sort orders, does not appear to push back any elements into the Vec if the sort order does not match TYPEORDER. I think the generated thrift parser would already have returned an error [here](https://github.com/apache/arrow-rs/blob/9c0cb9a56f0099e7d39087826d7e409ce0f1bf5f/parquet/src/format.rs#L5038) for an unknown `ColumnOrder`. I don't think it should panic though. What behavior would we want from a thrift parser? To avoid this problem, each generated enum would need to have some `UNKNOWN` / `UNSUPPORTED` variant. For `ColumnOrder` we could just ignore the statistics in that case, but I'm not sure whether in general this would just move the error to another place in the code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
