kevingurney commented on code in PR #47109:
URL: https://github.com/apache/arrow/pull/47109#discussion_r2207698077


##########
matlab/README.md:
##########
@@ -53,6 +53,10 @@ Supported `arrow.array.Array` types are included in the 
table below.
 | `datetime`        | `TimestampArray` |
 | `duration`        | `Time32Array`    |
 | `duration`        | `Time64Array`    |
+| `datetime`        | `Date32Array`    |

Review Comment:
   > We also may want to indicate the default MATLAB -> Arrow type mapping for 
`datetime` and `duration`.
   
   That's an interesting suggestion.
   
   The `README.md` doesn't formally specify what the type mappings in this 
table actually correspond to in terms of the available mlarrow APIs (e.g. 
`arrow.array()` or `arrow.array.<Type>Array.fromMATLAB()`).
   
   I made these updates according to what `arrow.array.<Type>Array.fromMATLAB` 
expects in terms of MATLAB types. Perhaps, this is sufficient for now?
   
   We could consider adding more fine-grained type mapping info in a future doc 
update.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to