hiroyuki-sato opened a new pull request, #47126:
URL: https://github.com/apache/arrow/pull/47126

   ### Rationale for this change
   
   This is the sub issue #44748.
   
   * SC2034: source_dir appears unused. Verify use (or export if used 
externally).
   * SC2086: Double quote to prevent globbing and word splitting.
   * SC2155: Declare and assign separately to avoid masking return values.
   
   ```
   shellcheck ci/scripts/integration_hdfs.sh
   
   In ci/scripts/integration_hdfs.sh line 22:
   source_dir=${1}/cpp
   ^--------^ SC2034 (warning): source_dir appears unused. Verify use (or 
export if used externally).
   
   
   In ci/scripts/integration_hdfs.sh line 25:
   export CLASSPATH=$($HADOOP_HOME/bin/hadoop classpath --glob)
          ^-------^ SC2155 (warning): Declare and assign separately to avoid 
masking return values.
                      ^----------^ SC2086 (info): Double quote to prevent 
globbing and word splitting.
   
   Did you mean:
   export CLASSPATH=$("$HADOOP_HOME"/bin/hadoop classpath --glob)
   
   
   In ci/scripts/integration_hdfs.sh line 45:
   pushd ${build_dir}
         ^----------^ SC2086 (info): Double quote to prevent globbing and word 
splitting.
   
   Did you mean:
   pushd "${build_dir}"
   
   For more information:
     https://www.shellcheck.net/wiki/SC2034 -- source_dir appears unused. 
Verify...
     https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to 
...
     https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing 
...
   ```
   
   ### What changes are included in this PR?
   
   * SC2034: disable shellcheck
   * SC2086: Quote variables.
   * SC2155: separate variable declaration and export.
   
   ### Are these changes tested?
   
   Yes.
   
   ### Are there any user-facing changes?
   
   No.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to