alamb commented on code in PR #7911:
URL: https://github.com/apache/arrow-rs/pull/7911#discussion_r2211516273
##########
parquet-variant-compute/src/variant_array_builder.rs:
##########
@@ -147,11 +147,9 @@ impl VariantArrayBuilder {
/// Append the [`Variant`] to the builder as the next row
pub fn append_variant(&mut self, variant: Variant) {
- // TODO make this more efficient by avoiding the intermediate buffers
- let mut variant_builder = VariantBuilder::new();
- variant_builder.append_value(variant);
- let (metadata, value) = variant_builder.finish();
Review Comment:
The whole point of this PR is to avoid this copy here and instead write
directly into the output
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
