birschick-bq commented on code in PR #3171:
URL: https://github.com/apache/arrow-adbc/pull/3171#discussion_r2211633003


##########
csharp/src/Drivers/Databricks/BaseDatabricksReader.cs:
##########
@@ -42,7 +42,7 @@ protected BaseDatabricksReader(DatabricksStatement statement, 
Schema schema, boo
             this.schema = schema;
             this.isLz4Compressed = isLz4Compressed;
             this.statement = statement;
-            if (statement.DirectResults != null && 
!statement.DirectResults.ResultSet.HasMoreRows)
+            if (statement.DirectResults != null && 
statement.DirectResults.ResultSet != null && 
!statement.DirectResults.ResultSet.HasMoreRows)

Review Comment:
   More concise?
   ```suggestion
               if (statement.DirectResults?.ResultSet?.HasMoreRows == true)
   ```



##########
csharp/src/Drivers/Databricks/DatabricksStatement.cs:
##########
@@ -73,6 +76,8 @@ protected override void 
SetStatementProperties(TExecuteStatementReq statement)
             statement.CanDecompressLZ4Result = canDecompressLz4;
             statement.MaxBytesPerFile = maxBytesPerFile;
 

Review Comment:
   nit: extra line
   ```suggestion
   ```



##########
csharp/src/Drivers/Databricks/DatabricksParameters.cs:
##########
@@ -180,6 +180,13 @@ public class DatabricksParameters : SparkParameters
         /// </summary>
         public const string UseDescTableExtended = 
"adbc.databricks.use_desc_table_extended";
 
+

Review Comment:
   nit: extra line
   ```suggestion
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to