WillAyd commented on code in PR #45272:
URL: https://github.com/apache/arrow/pull/45272#discussion_r2213535155
##########
cpp/src/arrow/compute/kernels/scalar_compare.cc:
##########
@@ -54,6 +55,39 @@ struct NotEqual {
}
};
+struct ListEqual {
+ template <typename T, typename Arg0, typename Arg1>
+ static T Call(KernelContext*, const Arg0& left, const Arg1& right, Status*) {
+ static_assert(std::is_same<T, bool>::value && std::is_same<Arg0,
Arg1>::value, "");
+
+ if (left.length != right.length) {
+ return false;
+ } else {
+ RangeDataEqualsImpl range_comparer{
+ EqualOptions::Defaults(), false, left, right, 0, 0, 1,
Review Comment:
I'm doubtful that hard-coding the offsets here at zero is correct, although
passing left.offset and right.offset was triggering heap overflow.
Is it possible for both the parent and child arrays to have a legitimate
offset, or does the list type manage that just through its child array?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
