scovich commented on code in PR #7943:
URL: https://github.com/apache/arrow-rs/pull/7943#discussion_r2214190973
##########
parquet-variant/src/builder.rs:
##########
@@ -216,6 +217,57 @@ impl ValueBuffer {
self.append_slice(value.as_bytes());
}
+ fn append_object(&mut self, metadata_builder: &mut MetadataBuilder, obj:
VariantObject) {
+ let mut object_builder = self.new_object(metadata_builder);
+
+ for (field_name, value) in obj.iter() {
+ object_builder.insert(field_name, value);
+ }
+
+ object_builder.finish().unwrap();
+ }
+
+ fn try_append_object(
+ &mut self,
+ metadata_builder: &mut MetadataBuilder,
+ obj: VariantObject,
+ ) -> Result<(), ArrowError> {
+ let mut object_builder = self.new_object(metadata_builder);
+
+ for res in obj.iter_try() {
Review Comment:
Except `append_object` is infallible... so even if we "consolidate" by
having `try_append_object` fall back to its infallible partner, both
similar-but-different for loops will still exist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
