alamb commented on PR #7963: URL: https://github.com/apache/arrow-rs/pull/7963#issuecomment-3089819637
Aha -- the CI test caught a real error: - https://github.com/apache/arrow-rs/actions/runs/16374023184/job/46269326079?pr=7963 ``` Checking arrow v55.2.0 (/__w/arrow-rs/arrow-rs/arrow) Checking parquet-variant-compute v0.1.0 (/__w/arrow-rs/arrow-rs/parquet-variant-compute) error: this expression creates a reference which is immediately dereferenced by the compiler --> parquet-variant-compute/src/variant_array.rs:98:70 | 98 | let Some(metadata_field) = VariantArray::find_metadata_field(&inner) else { | ^^^^^^ help: change this to: `inner` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-D clippy::needless-borrow` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]` error: this expression creates a reference which is immediately dereferenced by the compiler --> parquet-variant-compute/src/variant_array.rs:109:64 | 109 | let Some(value_field) = VariantArray::find_value_field(&inner) else { | ^^^^^^ help: change this to: `inner` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow error: could not compile `parquet-variant-compute` (lib) due to 2 previous errors ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
