wgtmac commented on code in PR #47090: URL: https://github.com/apache/arrow/pull/47090#discussion_r2217354178
########## cpp/src/parquet/properties.h: ########## @@ -155,6 +155,8 @@ class PARQUET_EXPORT ReaderProperties { ReaderProperties PARQUET_EXPORT default_reader_properties(); static constexpr int64_t kDefaultDataPageSize = 1024 * 1024; +/// FIXME: Switch the default value to 20000 will break UTs. +static constexpr int64_t kDefaultMaxRowsPerPage = 1000000; Review Comment: There are already examples like kDefaultDataPageSize and I think this is the right direction. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org