amoeba commented on code in PR #47121:
URL: https://github.com/apache/arrow/pull/47121#discussion_r2217363275
##########
r/NEWS.md:
##########
@@ -19,13 +19,25 @@
# arrow 20.0.0.9000
+## Breaking changes
Review Comment:
The two items here don't feel like breaking changes but I'm happy to be
convinced. They're not breaking in terms of any first-class use case or in
terms of any APIs. By first class use case, I mean "installing the package from
CRAN binaries" is a first class use case, where building from source is pretty
unusual and not what I'd call first class. We do provide users with the ability
to do so, so it's definitely worth mentioning.
What do you think about listing these as Minor improvements or a header
other than Breaking changes?
##########
r/NEWS.md:
##########
@@ -19,13 +19,25 @@
# arrow 20.0.0.9000
+## Breaking changes
+
+- Backwards compatibility checks for legacy libarrow versions have been
removed
+ from the R package (#46491).
+- Require cmake 3.25 in bundled build script for full-source builds (#46834).
Review Comment:
```suggestion
- Require CMake 3.25 or greater in bundled build script for full-source
builds (#46834). This shouldn't affect most users.
```
##########
r/NEWS.md:
##########
@@ -19,13 +19,25 @@
# arrow 20.0.0.9000
+## Breaking changes
+
+- Backwards compatibility checks for legacy libarrow versions have been
removed
+ from the R package (#46491).
Review Comment:
```suggestion
- Backwards compatibility checks for legacy Arrow C++ versions have been
removed
from the R package (#46491). This shouldn't affect most users this package
and would only impact you if you were building the R package from source with
different R package and Arrow C++ versions.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
