scovich commented on code in PR #7887:
URL: https://github.com/apache/arrow-rs/pull/7887#discussion_r2217522416


##########
arrow-cast/src/cast/mod.rs:
##########
@@ -891,7 +893,7 @@ pub fn cast_with_options(
                 scale,
                 from_type,
                 to_type,
-                |x: i256| x.to_f64().unwrap(),
+                |x: i256| decimal256_to_f64(x),

Review Comment:
   (just be careful -- the least-significant leading zero is the sign bit, and 
mustn't be shifted out; I'm not 100% certain my code above handles that 
correctly, could be off-by-one)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to