wgtmac commented on PR #47114: URL: https://github.com/apache/arrow/pull/47114#issuecomment-3095094159
``` FAILED: [code=2] src/parquet/CMakeFiles/parquet_shared.dir/arrow/path_internal.cc.obj "C:\Program Files\Git\usr\bin\ccache.exe" C:\PROGRA~1\MICROS~2\2022\ENTERP~1\VC\Tools\MSVC\1444~1.352\bin\Hostx64\x64\cl.exe /nologo /TP -DARROW_HAVE_RUNTIME_AVX2 -DARROW_HAVE_RUNTIME_AVX512 -DARROW_HAVE_RUNTIME_BMI2 -DARROW_HAVE_RUNTIME_SSE4_2 -DARROW_HAVE_SSE4_2 -DARROW_WITH_TIMING_TESTS -DHAVE_INTTYPES_H -DHAVE_NETDB_H -DNOMINMAX -DPARQUET_EXPORTING -DPARQUET_THRIFT_VERSION_MAJOR=0 -DPARQUET_THRIFT_VERSION_MINOR=20 -D_CRT_SECURE_NO_WARNINGS -D__SSE2__ -D__SSE4_1__ -D__SSE4_2__ -Dparquet_shared_EXPORTS -ID:\a\arrow\arrow\build\cpp\src -ID:\a\arrow\arrow\cpp\src -ID:\a\arrow\arrow\cpp\src\generated -external:ID:\a\arrow\arrow\build\cpp\vcpkg_installed\x64-windows\include -external:W0 /D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING /W3 /EHsc /wd5105 /bigobj /utf-8 /W3 /wd4365 /wd4267 /wd4838 /wd4800 /wd4996 /wd4065 /arch:SSE4.2 /Ob0 /Od /RTC1 /WX -std:c++17 -MDd -Zi /showIncludes /Fosrc\parquet\CMakeFiles\parquet_shared.dir\arrow\path_internal.cc.obj /Fdsrc\parquet\CMakeFiles\parqu et_shared.dir\ /FS -c D:\a\arrow\arrow\cpp\src\parquet\arrow\path_internal.cc D:\a\arrow\arrow\cpp\src\parquet/exception.h(87): error C2220: the following warning is treated as an error D:\a\arrow\arrow\cpp\src\parquet/exception.h(87): warning C4275: non dll-interface class 'std::exception' used as base for dll-interface class 'parquet::ParquetException' C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.44.35207\include\vcruntime_exception.h(49): note: see declaration of 'std::exception' D:\a\arrow\arrow\cpp\src\parquet/exception.h(87): note: see declaration of 'parquet::ParquetException' [318/403] Building CXX object src\arrow\flight\CMakeFiles\arrow_flight_shared.dir\transport\grpc\protocol_grpc_internal.cc.obj [319/403] Building CXX object src\parquet\CMakeFiles\parquet_shared.dir\arrow\reader.cc.obj FAILED: [code=2] src/parquet/CMakeFiles/parquet_shared.dir/arrow/reader.cc.obj "C:\Program Files\Git\usr\bin\ccache.exe" C:\PROGRA~1\MICROS~2\2022\ENTERP~1\VC\Tools\MSVC\1444~1.352\bin\Hostx64\x64\cl.exe /nologo /TP -DARROW_HAVE_RUNTIME_AVX2 -DARROW_HAVE_RUNTIME_AVX512 -DARROW_HAVE_RUNTIME_BMI2 -DARROW_HAVE_RUNTIME_SSE4_2 -DARROW_HAVE_SSE4_2 -DARROW_WITH_TIMING_TESTS -DHAVE_INTTYPES_H -DHAVE_NETDB_H -DNOMINMAX -DPARQUET_EXPORTING -DPARQUET_THRIFT_VERSION_MAJOR=0 -DPARQUET_THRIFT_VERSION_MINOR=20 -D_CRT_SECURE_NO_WARNINGS -D__SSE2__ -D__SSE4_1__ -D__SSE4_2__ -Dparquet_shared_EXPORTS -ID:\a\arrow\arrow\build\cpp\src -ID:\a\arrow\arrow\cpp\src -ID:\a\arrow\arrow\cpp\src\generated -external:ID:\a\arrow\arrow\build\cpp\vcpkg_installed\x64-windows\include -external:W0 /D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING /W3 /EHsc /wd5105 /bigobj /utf-8 /W3 /wd4365 /wd4267 /wd4838 /wd4800 /wd4996 /wd4065 /arch:SSE4.2 /Ob0 /Od /RTC1 /WX -std:c++17 -MDd -Zi /showIncludes /Fosrc\parquet\CMakeFiles\parquet_shared.dir\arrow\reader.cc.obj /Fdsrc\parquet\CMakeFiles\parquet_shar ed.dir\ /FS -c D:\a\arrow\arrow\cpp\src\parquet\arrow\reader.cc D:\a\arrow\arrow\cpp\src\parquet/exception.h(87): error C2220: the following warning is treated as an error D:\a\arrow\arrow\cpp\src\parquet/exception.h(87): warning C4275: non dll-interface class 'std::exception' used as base for dll-interface class 'parquet::ParquetException' C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.44.35207\include\vcruntime_exception.h(49): note: see declaration of 'std::exception' D:\a\arrow\arrow\cpp\src\parquet/exception.h(87): note: see declaration of 'parquet::ParquetException' ``` From the above log, `warning C4275` is fired but it should be disabled already via `pragma warning(disable : 4275 4251)`. I guess the reason is that adding `pragma warning(pop)` to the `parquet/platform.h` header file will immediately swipe out all pushed pragmas at the end of this header file and any source file including `parquet/platform.h` will not see any pushed pragmas any more. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
