alamb commented on code in PR #7965:
URL: https://github.com/apache/arrow-rs/pull/7965#discussion_r2219540524
##########
parquet-variant-compute/src/variant_array_builder.rs:
##########
@@ -146,7 +146,7 @@ impl VariantArrayBuilder {
}
/// Append the [`Variant`] to the builder as the next row
- pub fn append_variant(&mut self, variant: Variant) {
+ pub fn append_variant<'m, 'v>(&mut self, variant: impl Into<Variant<'m,
'v>>) {
// TODO make this more efficient by avoiding the intermediate buffers
Review Comment:
If you are concerned about the intermediate buffers, I think after the
following two PRs are merged:
- https://github.com/apache/arrow-rs/pull/7911
- https://github.com/apache/arrow-rs/pull/7935
There will be a way to append variant values to the final output buffer
directly without copying to intermediate buffers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
