jecsand838 commented on code in PR #7966:
URL: https://github.com/apache/arrow-rs/pull/7966#discussion_r2220411696
##########
arrow-avro/src/reader/mod.rs:
##########
@@ -365,11 +371,7 @@ impl<R: BufRead> Reader<R> {
}
// Try to decode more rows from the current block.
let consumed =
self.decoder.decode(&self.block_data[self.block_cursor..])?;
- if consumed == 0 && self.block_cursor < self.block_data.len() {
- self.block_cursor = self.block_data.len();
Review Comment:
@scovich Yeah it was an over-aggressive guardrail and since this crate isn't
public I probably should have gone with your original recommendation. I was
just unsure of what work needed to be done to support zero-byte encodings and
wanted time to do the research and an integration test to confirm it.
This PR ended up being much smaller than I anticipated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
