viirya commented on code in PR #7911: URL: https://github.com/apache/arrow-rs/pull/7911#discussion_r2223420083
########## parquet-variant-compute/src/variant_array_builder.rs: ########## @@ -55,9 +55,14 @@ use std::sync::Arc; /// }; /// builder.append_variant_buffers(&metadata, &value); Review Comment: The new approach is more efficient. Do we still need to have `append_variant_buffers`? Does it still make sense to create a `VariantBuilder`, build metadata and buffer and append them with `append_variant_buffers`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
