collinoc opened a new pull request, #447:
URL: https://github.com/apache/arrow-rs-object-store/pull/447
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #446.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
Currently there seems to be no support for applying implementation specific
attributes within this API. For example with a `aws_store.put_opts(...)` call,
there would be no way to specify a [`x-amz-object-lock-mode`
attribute](https://docs.aws.amazon.com/AmazonS3/latest/API/API_PutObject.html#API_PutObject_RequestSyntax),
or applying
[`x-goog-storage-class`](https://cloud.google.com/storage/docs/xml-api/reference-headers#xgoogstorageclass)
for a GCP put operation. This adds support for such use cases.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
Expands the `Attribute` enum to include a `Other` variant that will add
headers with implementation specific prefixes (`x-amz-` for AWS, etc.)
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
Yes, documentation was updated where I thought needed. Let me know if more
is needed.
<!---
If there are any breaking changes to public APIs, please call them out.
-->
These changes should be backwards compatible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
