jackyhu-db commented on PR #3189: URL: https://github.com/apache/arrow-adbc/pull/3189#issuecomment-3105212203
> > > This is definitely not needed for `GetCrossReferenceAsForeignTableAsync`? Should there be a comment to that effect? > > > > > > If we do not set this, CloseOperation will be called if the client calls `GetCrossReferenceAsForeignTableAsync` > > Sorry, I didn't word that very well. Every method that calls `GetQueryResult` was changed except for `GetCrossReferenceAsForeignTableAsync` so I just wanted to confirm that this is correct. Thanks for catching this. It should be added as well, uploaded a fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
