carpecodeum commented on PR #7946: URL: https://github.com/apache/arrow-rs/pull/7946#issuecomment-3105268918
After taking another look at both this PR and other PRs that have been opened or merged over the week, it seems like the only non-duplicate portions of this PR are the "get_field_names" and the "remove_field(s)" functionality. I've deduplicated this PR and cleaned things up to reflect this current status. @scovitch has mentioned (https://github.com/apache/arrow-rs/pull/7935) that efficient, in-place Variant mutators are a piece that's still missing. Field removal naturally fits into a PR focused on that functionality. I can take "add_field(s)" if we'd like both append and removal functionality as part of the initial implementation. Separately, convenience functions to streamline interacting with Variants seem to be absent as well. Is there an interest in implementing traits for Variants like Index/IndexMut? I'm happy to take either of these efforts. Thanks @ scovitch and @ alamb for reviewing. Do we think this PR is both substantial and useful enough on its own? Or, do we want to close this PR and open one that's more targeted? I'm happy to follow through with either, favoring whatever the reviewers think would keep things clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
