ff-kamal opened a new pull request, #47178:
URL: https://github.com/apache/arrow/pull/47178

   ### Rationale for this change
   
   It seems as part of #45089 `FileSystem.from_uri` was changed from a static 
function to a regular method. I believe this to be an error unintentionally 
introduced as part of the PR, based on the fact that this was not mentioned to 
be an explicit change, and released as part of version 21.0. Previously, it was 
a staticmethod on the class.
   
   This PR adds the `@staticmethod` annotation back to this method.
   
   ### What changes are included in this PR?
   
   `FileSystem.from_uri` is now a static method again.
   
   ### Are these changes tested?
   
   Yes.
   
   ### Are there any user-facing changes?
   
   Yes, to the `FileSystem.from_uri` function.
   
   **This PR includes breaking changes to public APIs.**
   
   Yes, this changes how `FileSystem.from_uri` should be called by users. This 
was already broken when upgrading to version 21.0, but if users had changed to 
no longer depend on it being a static method, this would break them in a future 
upgrade.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to