lidavidm commented on a change in pull request #9947:
URL: https://github.com/apache/arrow/pull/9947#discussion_r612380101
##########
File path: cpp/src/arrow/dataset/test_util.h
##########
@@ -136,6 +138,15 @@ class DatasetFixtureMixin : public ::testing::Test {
}
}
+ /// \brief Ensure a record batch yielded by the fragment matches the next
batch yielded
+ /// by the reader
+ void AssertBatchEquals(RecordBatchReader* expected, RecordBatch* batch) {
Review comment:
We generally favor pointers over non-const reference parameters, IIRC to
make it clear what is used mutably, but I can't find the reference for this (I
had thought it was in the Google C++ Style Guide).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
